Re: [libvirt] [PATCH v2 01/12] conf: Fix possible memleak in capabilities

2017-04-06 Thread Erik Skultety
On Thu, Apr 06, 2017 at 11:52:54AM +0200, Martin Kletzander wrote: > On Thu, Apr 06, 2017 at 11:29:21AM +0200, Erik Skultety wrote: > > On Thu, Apr 06, 2017 at 11:12:54AM +0200, Martin Kletzander wrote: > > > On Thu, Apr 06, 2017 at 09:50:49AM +0200, Erik Skultety wrote: > > > > On Wed, Apr 05,

Re: [libvirt] [PATCH v2 01/12] conf: Fix possible memleak in capabilities

2017-04-06 Thread Martin Kletzander
On Thu, Apr 06, 2017 at 11:29:21AM +0200, Erik Skultety wrote: On Thu, Apr 06, 2017 at 11:12:54AM +0200, Martin Kletzander wrote: On Thu, Apr 06, 2017 at 09:50:49AM +0200, Erik Skultety wrote: > On Wed, Apr 05, 2017 at 04:36:24PM +0200, Martin Kletzander wrote: > > If formatting NUMA topology

Re: [libvirt] [PATCH v2 01/12] conf: Fix possible memleak in capabilities

2017-04-06 Thread Erik Skultety
On Thu, Apr 06, 2017 at 11:12:54AM +0200, Martin Kletzander wrote: > On Thu, Apr 06, 2017 at 09:50:49AM +0200, Erik Skultety wrote: > > On Wed, Apr 05, 2017 at 04:36:24PM +0200, Martin Kletzander wrote: > > > If formatting NUMA topology fails, the function returns immediatelly, > > > but the

Re: [libvirt] [PATCH v2 01/12] conf: Fix possible memleak in capabilities

2017-04-06 Thread Martin Kletzander
On Thu, Apr 06, 2017 at 09:50:49AM +0200, Erik Skultety wrote: On Wed, Apr 05, 2017 at 04:36:24PM +0200, Martin Kletzander wrote: If formatting NUMA topology fails, the function returns immediatelly, but the buffer structure allocated on the stack references lot of heap-allocated memory and

Re: [libvirt] [PATCH v2 01/12] conf: Fix possible memleak in capabilities

2017-04-06 Thread Peter Krempa
On Thu, Apr 06, 2017 at 09:50:49 +0200, Erik Skultety wrote: > On Wed, Apr 05, 2017 at 04:36:24PM +0200, Martin Kletzander wrote: > > If formatting NUMA topology fails, the function returns immediatelly, > > but the buffer structure allocated on the stack references lot of > > heap-allocated

Re: [libvirt] [PATCH v2 01/12] conf: Fix possible memleak in capabilities

2017-04-06 Thread Erik Skultety
On Wed, Apr 05, 2017 at 04:36:24PM +0200, Martin Kletzander wrote: > If formatting NUMA topology fails, the function returns immediatelly, > but the buffer structure allocated on the stack references lot of > heap-allocated memory and that would get lost in such case. > > Signed-off-by: Martin

[libvirt] [PATCH v2 01/12] conf: Fix possible memleak in capabilities

2017-04-05 Thread Martin Kletzander
If formatting NUMA topology fails, the function returns immediatelly, but the buffer structure allocated on the stack references lot of heap-allocated memory and that would get lost in such case. Signed-off-by: Martin Kletzander --- src/conf/capabilities.c | 6 +- 1