Re: [libvirt] [PATCH v2 01/21] qemu: Introduce qemuDomainChrDefPostParse()

2017-11-22 Thread Marc Hartmayer
On Tue, Nov 21, 2017 at 05:42 PM +0100, Andrea Bolognani wrote: > Having a separate function for char device handling is better than > adding even more code to qemuDomainDeviceDefPostParse(). > > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_domain.c | 57 >

Re: [libvirt] [PATCH v2 01/21] qemu: Introduce qemuDomainChrDefPostParse()

2017-11-21 Thread Pavel Hrdina
On Tue, Nov 21, 2017 at 05:42:11PM +0100, Andrea Bolognani wrote: > Having a separate function for char device handling is better than > adding even more code to qemuDomainDeviceDefPostParse(). > > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_domain.c | 57 > +++

[libvirt] [PATCH v2 01/21] qemu: Introduce qemuDomainChrDefPostParse()

2017-11-21 Thread Andrea Bolognani
Having a separate function for char device handling is better than adding even more code to qemuDomainDeviceDefPostParse(). Signed-off-by: Andrea Bolognani --- src/qemu/qemu_domain.c | 57 ++ 1 file changed, 34 insertions(+), 23 deletions(-) diff