Re: [libvirt] [PATCH v2 01/22] virt-aa-helper: Trick invalid syntax-check

2014-11-13 Thread John Ferlan
On 11/13/2014 09:37 AM, Martin Kletzander wrote: > Rule sc_prohibit_newline_at_end_of_diagnostic for syntax-check does > check for passing strings ending with '\n' to known functions. But when > setting IFS, '\n' needs to be part of that (and is by default). The > order of individual characters

Re: [libvirt] [PATCH v2 01/22] virt-aa-helper: Trick invalid syntax-check

2014-11-13 Thread Eric Blake
On 11/13/2014 07:37 AM, Martin Kletzander wrote: > Rule sc_prohibit_newline_at_end_of_diagnostic for syntax-check does > check for passing strings ending with '\n' to known functions. But when > setting IFS, '\n' needs to be part of that (and is by default). The > order of individual characters i

[libvirt] [PATCH v2 01/22] virt-aa-helper: Trick invalid syntax-check

2014-11-13 Thread Martin Kletzander
Rule sc_prohibit_newline_at_end_of_diagnostic for syntax-check does check for passing strings ending with '\n' to known functions. But when setting IFS, '\n' needs to be part of that (and is by default). The order of individual characters in IFS doesn't matter, so transposing last two of them fix