Re: [libvirt] [PATCH v2 02/12] qemu: Introduce qemuDomainSecretPrepare and Destroy

2016-05-02 Thread Ján Tomko
On Mon, May 02, 2016 at 08:48:02AM -0400, John Ferlan wrote: > On 05/02/2016 07:38 AM, Ján Tomko wrote: > > On Sat, Apr 16, 2016 at 10:17:35AM -0400, John Ferlan wrote: > >> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c > >> index 81d86c2..c9f43fa 100644 > >> --- a/src/qemu/qemu_pr

Re: [libvirt] [PATCH v2 02/12] qemu: Introduce qemuDomainSecretPrepare and Destroy

2016-05-02 Thread Ján Tomko
On Mon, May 02, 2016 at 10:08:10AM -0400, John Ferlan wrote: > > > On 05/02/2016 09:52 AM, Ján Tomko wrote: > > On Mon, May 02, 2016 at 08:48:02AM -0400, John Ferlan wrote: > >> On 05/02/2016 07:38 AM, Ján Tomko wrote: > >>> On Sat, Apr 16, 2016 at 10:17:35AM -0400, John Ferlan wrote: > diff

Re: [libvirt] [PATCH v2 02/12] qemu: Introduce qemuDomainSecretPrepare and Destroy

2016-05-02 Thread John Ferlan
On 05/02/2016 09:52 AM, Ján Tomko wrote: > On Mon, May 02, 2016 at 08:48:02AM -0400, John Ferlan wrote: >> On 05/02/2016 07:38 AM, Ján Tomko wrote: >>> On Sat, Apr 16, 2016 at 10:17:35AM -0400, John Ferlan wrote: diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 81d86

Re: [libvirt] [PATCH v2 02/12] qemu: Introduce qemuDomainSecretPrepare and Destroy

2016-05-02 Thread John Ferlan
On 05/02/2016 07:38 AM, Ján Tomko wrote: > On Sat, Apr 16, 2016 at 10:17:35AM -0400, John Ferlan wrote: >> Rather than needing to pass the conn parameter to various command >> line building API's, add qemuDomainSecretPrepare just prior to the >> qemuProcessLaunch which calls qemuBuilCommandLine.

Re: [libvirt] [PATCH v2 02/12] qemu: Introduce qemuDomainSecretPrepare and Destroy

2016-05-02 Thread Ján Tomko
On Sat, Apr 16, 2016 at 10:17:35AM -0400, John Ferlan wrote: > Rather than needing to pass the conn parameter to various command > line building API's, add qemuDomainSecretPrepare just prior to the > qemuProcessLaunch which calls qemuBuilCommandLine. The function > must be called after qemuProcessP

Re: [libvirt] [PATCH v2 02/12] qemu: Introduce qemuDomainSecretPrepare and Destroy

2016-04-28 Thread John Ferlan
[...] >> >> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c >> index 26c19ff..24ed8ed 100644 >> --- a/src/qemu/qemu_command.c >> +++ b/src/qemu/qemu_command.c >> @@ -832,7 +832,7 @@ qemuBuildNetworkDriveURI(virStorageSourcePtr src, >> >> int >> qemuGetDriveSourceString(virStor

Re: [libvirt] [PATCH v2 02/12] qemu: Introduce qemuDomainSecretPrepare and Destroy

2016-04-27 Thread Cole Robinson
On 04/16/2016 10:17 AM, John Ferlan wrote: > Rather than needing to pass the conn parameter to various command > line building API's, add qemuDomainSecretPrepare just prior to the > qemuProcessLaunch which calls qemuBuilCommandLine. The function > must be called after qemuProcessPrepareHost since i

[libvirt] [PATCH v2 02/12] qemu: Introduce qemuDomainSecretPrepare and Destroy

2016-04-16 Thread John Ferlan
Rather than needing to pass the conn parameter to various command line building API's, add qemuDomainSecretPrepare just prior to the qemuProcessLaunch which calls qemuBuilCommandLine. The function must be called after qemuProcessPrepareHost since it's expected to eventually need the domain masterKe