Re: [libvirt] [PATCH v2 02/20] virlog: Introduce virLogOutputNew

2016-09-23 Thread John Ferlan
[...] >>> + >>> +ret->logInitMessage = true; >>> +ret->f = f; >>> +ret->c = c; >>> +ret->data = data; >> >> From future patches I see this can be a file or syslog fd. >> >> Anyway, because you're relying on the "->c" to be the free function for >> ->data, perhaps there should be a

Re: [libvirt] [PATCH v2 02/20] virlog: Introduce virLogOutputNew

2016-09-23 Thread Erik Skultety
On 21/09/16 19:55, John Ferlan wrote: > > > On 08/18/2016 07:47 AM, Erik Skultety wrote: >> Continuing with the refactor, in order to later split output parsing and >> output > > s/Continuing with the refactor, i/I > >> defining, introduce a new function which will create a new virLogOutput

Re: [libvirt] [PATCH v2 02/20] virlog: Introduce virLogOutputNew

2016-09-21 Thread John Ferlan
On 08/18/2016 07:47 AM, Erik Skultety wrote: > Continuing with the refactor, in order to later split output parsing and > output s/Continuing with the refactor, i/I > defining, introduce a new function which will create a new virLogOutput object > which parser will insert into a list with the

[libvirt] [PATCH v2 02/20] virlog: Introduce virLogOutputNew

2016-08-18 Thread Erik Skultety
Continuing with the refactor, in order to later split output parsing and output defining, introduce a new function which will create a new virLogOutput object which parser will insert into a list with the list being eventually defined. Signed-off-by: Erik Skultety ---