Re: [libvirt] [PATCH v2 02/32] util: Rework virStorageAuthDefCopy

2019-02-11 Thread Ján Tomko
On Fri, Feb 08, 2019 at 01:36:56PM -0500, John Ferlan wrote: Rather than having an error path, let's rework the code to allocate and fill into an @authdef variable and then steal that into @ret when we are successful leaving just a cleanup: path. Signed-off-by: John Ferlan Reviewed-by: Erik Sku

[libvirt] [PATCH v2 02/32] util: Rework virStorageAuthDefCopy

2019-02-08 Thread John Ferlan
Rather than having an error path, let's rework the code to allocate and fill into an @authdef variable and then steal that into @ret when we are successful leaving just a cleanup: path. Signed-off-by: John Ferlan Reviewed-by: Erik Skultety --- src/util/virstoragefile.c | 26 +---