Re: [libvirt] [PATCH v2 03/12] migration: move implementation check to branches in p2p

2015-09-18 Thread Nikolay Shirokovskiy
On 17.09.2015 01:24, John Ferlan wrote: > > > On 09/10/2015 09:20 AM, Nikolay Shirokovskiy wrote: >> This is more structured code so it will be easier to add branch for _PARAMS >> protocol here. It is not a pure refactoring strictly speaking as we remove >> scenarios for broken cases when

Re: [libvirt] [PATCH v2 03/12] migration: move implementation check to branches in p2p

2015-09-17 Thread Daniel P. Berrange
On Thu, Sep 10, 2015 at 04:20:15PM +0300, Nikolay Shirokovskiy wrote: > This is more structured code so it will be easier to add branch for _PARAMS > protocol here. It is not a pure refactoring strictly speaking as we remove > scenarios for broken cases when driver defines V3 feature and

Re: [libvirt] [PATCH v2 03/12] migration: move implementation check to branches in p2p

2015-09-16 Thread John Ferlan
On 09/10/2015 09:20 AM, Nikolay Shirokovskiy wrote: > This is more structured code so it will be easier to add branch for _PARAMS > protocol here. It is not a pure refactoring strictly speaking as we remove > scenarios for broken cases when driver defines V3 feature and implements > perform

[libvirt] [PATCH v2 03/12] migration: move implementation check to branches in p2p

2015-09-10 Thread Nikolay Shirokovskiy
This is more structured code so it will be easier to add branch for _PARAMS protocol here. It is not a pure refactoring strictly speaking as we remove scenarios for broken cases when driver defines V3 feature and implements perform function. So it is additionally a more solid code. Signed-off-by: