Re: [libvirt] [PATCH v2 04/11] qemu: handle host usb device add/del udev events

2019-09-16 Thread Nikolay Shirokovskiy
On 16.09.2019 12:03, Peter Krempa wrote: > On Mon, Sep 16, 2019 at 08:53:10 +, Nikolay Shirokovskiy wrote: >> >> >> On 16.09.2019 11:26, Peter Krempa wrote: >>> On Mon, Sep 09, 2019 at 14:33:07 +0300, Nikolay Shirokovskiy wrote: Now when code handling attaching/detaching usb hostdev is

Re: [libvirt] [PATCH v2 04/11] qemu: handle host usb device add/del udev events

2019-09-16 Thread Peter Krempa
On Mon, Sep 16, 2019 at 08:53:10 +, Nikolay Shirokovskiy wrote: > > > On 16.09.2019 11:26, Peter Krempa wrote: > > On Mon, Sep 09, 2019 at 14:33:07 +0300, Nikolay Shirokovskiy wrote: > >> Now when code handling attaching/detaching usb hostdev is appropriately > >> changed use it to handle

Re: [libvirt] [PATCH v2 04/11] qemu: handle host usb device add/del udev events

2019-09-16 Thread Nikolay Shirokovskiy
On 16.09.2019 11:26, Peter Krempa wrote: > On Mon, Sep 09, 2019 at 14:33:07 +0300, Nikolay Shirokovskiy wrote: >> Now when code handling attaching/detaching usb hostdev is appropriately >> changed use it to handle host usb device udev add/del events. >> >> Signed-off-by: Nikolay Shirokovskiy

Re: [libvirt] [PATCH v2 04/11] qemu: handle host usb device add/del udev events

2019-09-16 Thread Peter Krempa
On Mon, Sep 09, 2019 at 14:33:07 +0300, Nikolay Shirokovskiy wrote: > Now when code handling attaching/detaching usb hostdev is appropriately > changed use it to handle host usb device udev add/del events. > > Signed-off-by: Nikolay Shirokovskiy > --- > src/qemu/Makefile.inc.am | 2 + >

Re: [libvirt] [PATCH v2 04/11] qemu: handle host usb device add/del udev events

2019-09-12 Thread Daniel Henrique Barboza
On 9/9/19 8:33 AM, Nikolay Shirokovskiy wrote: Now when code handling attaching/detaching usb hostdev is appropriately changed use it to handle host usb device udev add/del events. Assuming we're ok with adding an extra dependency (libudev), LGTM. Reviewed-by: Daniel Henrique Barboza

[libvirt] [PATCH v2 04/11] qemu: handle host usb device add/del udev events

2019-09-09 Thread Nikolay Shirokovskiy
Now when code handling attaching/detaching usb hostdev is appropriately changed use it to handle host usb device udev add/del events. Signed-off-by: Nikolay Shirokovskiy --- src/qemu/Makefile.inc.am | 2 + src/qemu/qemu_conf.h | 3 + src/qemu/qemu_domain.c | 2 +