Re: [libvirt] [PATCH v2 05/11] qemuDomainDefPostParse: Fetch qemuCaps from domain object

2016-09-26 Thread Jiri Denemark
On Fri, Sep 23, 2016 at 15:24:58 +0200, Michal Privoznik wrote: > We can't rely on def->emulator path. It may be provided by user > as we give them opportunity to provide their own XML for > migration. Therefore the path may point to just whatever binary > (or even to a non-existent file). Moreover

[libvirt] [PATCH v2 05/11] qemuDomainDefPostParse: Fetch qemuCaps from domain object

2016-09-23 Thread Michal Privoznik
We can't rely on def->emulator path. It may be provided by user as we give them opportunity to provide their own XML for migration. Therefore the path may point to just whatever binary (or even to a non-existent file). Moreover, this path is meant for destination, but the capabilities lookup is don