Re: [libvirt] [PATCH v2 05/12] migration: refactor: merge direct and p2p into unmanaged

2015-09-18 Thread Nikolay Shirokovskiy
On 17.09.2015 02:11, John Ferlan wrote: > > > On 09/10/2015 09:20 AM, Nikolay Shirokovskiy wrote: >> p2p plain and direct function are good candidates for code reuse. Their main >> function is same - to branch among different versions of migration protocol >> and >> implementation of this

Re: [libvirt] [PATCH v2 05/12] migration: refactor: merge direct and p2p into unmanaged

2015-09-17 Thread Daniel P. Berrange
On Thu, Sep 10, 2015 at 04:20:17PM +0300, Nikolay Shirokovskiy wrote: > p2p plain and direct function are good candidates for code reuse. Their main > function is same - to branch among different versions of migration protocol > and > implementation of this function is also same. Also they have

Re: [libvirt] [PATCH v2 05/12] migration: refactor: merge direct and p2p into unmanaged

2015-09-16 Thread John Ferlan
On 09/10/2015 09:20 AM, Nikolay Shirokovskiy wrote: > p2p plain and direct function are good candidates for code reuse. Their main > function is same - to branch among different versions of migration protocol > and > implementation of this function is also same. Also they have other common >

Re: [libvirt] [PATCH v2 05/12] migration: refactor: merge direct and p2p into unmanaged

2015-09-16 Thread John Ferlan
Of course I sent it too quick - one extra note... [ ... snip... ] > /** > * virDomainMigrate: > * @domain: a domain object > @@ -3594,8 +3532,8 @@ virDomainMigrate(virDomainPtr domain, > } > > VIR_DEBUG("Using peer2peer migration"); > -if

[libvirt] [PATCH v2 05/12] migration: refactor: merge direct and p2p into unmanaged

2015-09-10 Thread Nikolay Shirokovskiy
p2p plain and direct function are good candidates for code reuse. Their main function is same - to branch among different versions of migration protocol and implementation of this function is also same. Also they have other common functionality in lesser aspects. So let's merge them. But as they