Re: [libvirt] [PATCH v2 05/15] conf: Introduce VIR_DOMAIN_LOADER_TYPE_NONE

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 10:29:15AM +0100, Michal Privoznik wrote: > This is going to extend virDomainLoader enum. The reason is that > once loader path is NULL its type makes no sense. However, since > value of zero corresponds to VIR_DOMAIN_LOADER_TYPE_ROM the > following XML would be produced: >

[libvirt] [PATCH v2 05/15] conf: Introduce VIR_DOMAIN_LOADER_TYPE_NONE

2019-03-07 Thread Michal Privoznik
This is going to extend virDomainLoader enum. The reason is that once loader path is NULL its type makes no sense. However, since value of zero corresponds to VIR_DOMAIN_LOADER_TYPE_ROM the following XML would be produced: ... To solve this, introduce VIR_DOMAIN_LOADER_TYPE_NONE