Re: [libvirt] [PATCH v2 05/15] vbox: Cleanup vboxAttachDrives implementation

2017-11-03 Thread John Ferlan
On 11/03/2017 12:19 PM, Dawid Zamirski wrote: > On Fri, 2017-11-03 at 09:43 -0400, John Ferlan wrote: >> >> On 10/24/2017 03:35 PM, Dawid Zamirski wrote: >>> This commit primes vboxAttachDrives for further changes so when >>> they >>> are made, the diff is less noisy: >>> >>> * move variable

Re: [libvirt] [PATCH v2 05/15] vbox: Cleanup vboxAttachDrives implementation

2017-11-03 Thread Dawid Zamirski
On Fri, 2017-11-03 at 09:43 -0400, John Ferlan wrote: > > On 10/24/2017 03:35 PM, Dawid Zamirski wrote: > > This commit primes vboxAttachDrives for further changes so when > > they > > are made, the diff is less noisy: > > > > * move variable declarations to the top of the function > > * add

Re: [libvirt] [PATCH v2 05/15] vbox: Cleanup vboxAttachDrives implementation

2017-11-03 Thread John Ferlan
On 10/24/2017 03:35 PM, Dawid Zamirski wrote: > This commit primes vboxAttachDrives for further changes so when they > are made, the diff is less noisy: > > * move variable declarations to the top of the function > * add disk variable to replace all the def->disks[i] instances > * add cleanup

[libvirt] [PATCH v2 05/15] vbox: Cleanup vboxAttachDrives implementation

2017-10-24 Thread Dawid Zamirski
This commit primes vboxAttachDrives for further changes so when they are made, the diff is less noisy: * move variable declarations to the top of the function * add disk variable to replace all the def->disks[i] instances * add cleanup at the end of the loop body, so it's all in one place