Re: [libvirt] [PATCH v2 06/11] qemu: Grab modify job for changing domain XML

On 05.06.2019 12:09, Michal Privoznik wrote: > Changing domain definition must be guarded with acquiring modify > job. The problem is if there is a thread executing say > qemuDomainSetMemoryStatsPeriod() which is an API that acquires > modify job and then possibly unlock the domain object and

Re: [libvirt] [PATCH v2 06/11] qemu: Grab modify job for changing domain XML

On 05.06.2019 12:09, Michal Privoznik wrote: > Changing domain definition must be guarded with acquiring modify > job. The problem is if there is a thread executing say > qemuDomainSetMemoryStatsPeriod() which is an API that acquires > modify job and then possibly unlock the domain object and

Re: [libvirt] [PATCH v2 06/11] qemu: Grab modify job for changing domain XML

On 6/5/19 11:32 AM, Peter Krempa wrote: On Wed, Jun 05, 2019 at 11:09:14 +0200, Michal Privoznik wrote: Changing domain definition must be guarded with acquiring modify job. The problem is if there is a thread executing say qemuDomainSetMemoryStatsPeriod() which is an API that acquires modify

Re: [libvirt] [PATCH v2 06/11] qemu: Grab modify job for changing domain XML

On Wed, Jun 05, 2019 at 11:09:14 +0200, Michal Privoznik wrote: > Changing domain definition must be guarded with acquiring modify > job. The problem is if there is a thread executing say > qemuDomainSetMemoryStatsPeriod() which is an API that acquires > modify job and then possibly unlock the

[libvirt] [PATCH v2 06/11] qemu: Grab modify job for changing domain XML

Changing domain definition must be guarded with acquiring modify job. The problem is if there is a thread executing say qemuDomainSetMemoryStatsPeriod() which is an API that acquires modify job and then possibly unlock the domain object and locks it again. However, becasue virDomainObjAssignDef()