Re: [libvirt] [PATCH v2 06/12] qemu: Generate cmd line at startup

2018-03-09 Thread Michal Privoznik
On 03/08/2018 01:18 AM, John Ferlan wrote: > > > On 03/06/2018 12:31 PM, Michal Privoznik wrote: >> On 03/02/2018 02:22 PM, John Ferlan wrote: >>> >>> >>> On 02/21/2018 01:11 PM, Michal Privoznik wrote: >>> What happens when there's more than one disk using the managed mode >>> where you have a

Re: [libvirt] [PATCH v2 06/12] qemu: Generate cmd line at startup

2018-03-07 Thread John Ferlan
On 03/06/2018 12:31 PM, Michal Privoznik wrote: > On 03/02/2018 02:22 PM, John Ferlan wrote: >> >> >> On 02/21/2018 01:11 PM, Michal Privoznik wrote: >>> This is the easier part. All we need to do here is put -object >>> pr-manger-helper,id=$alias,path=$socketPath and then just >>> reference the

Re: [libvirt] [PATCH v2 06/12] qemu: Generate cmd line at startup

2018-03-06 Thread Michal Privoznik
On 03/02/2018 02:22 PM, John Ferlan wrote: > > > On 02/21/2018 01:11 PM, Michal Privoznik wrote: >> This is the easier part. All we need to do here is put -object >> pr-manger-helper,id=$alias,path=$socketPath and then just >> reference the object in -drive file.pr-manger=$alias. > > s/manger/ma

Re: [libvirt] [PATCH v2 06/12] qemu: Generate cmd line at startup

2018-03-02 Thread Peter Krempa
On Fri, Mar 02, 2018 at 08:22:32 -0500, John Ferlan wrote: > > > On 02/21/2018 01:11 PM, Michal Privoznik wrote: > > This is the easier part. All we need to do here is put -object > > pr-manger-helper,id=$alias,path=$socketPath and then just > > reference the object in -drive file.pr-manger=$alia

Re: [libvirt] [PATCH v2 06/12] qemu: Generate cmd line at startup

2018-03-02 Thread John Ferlan
On 02/21/2018 01:11 PM, Michal Privoznik wrote: > This is the easier part. All we need to do here is put -object > pr-manger-helper,id=$alias,path=$socketPath and then just > reference the object in -drive file.pr-manger=$alias. s/manger/manager/ My fingers usually the same way though as manger

[libvirt] [PATCH v2 06/12] qemu: Generate cmd line at startup

2018-02-21 Thread Michal Privoznik
This is the easier part. All we need to do here is put -object pr-manger-helper,id=$alias,path=$socketPath and then just reference the object in -drive file.pr-manger=$alias. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c| 40 ++ .../d