Re: [libvirt] [PATCH v2 06/15] util: Modify the FileTypeInfo to add a version size

2016-06-24 Thread John Ferlan
[...] >> >>> @@ -635,13 +637,25 @@ virStorageFileMatchesVersion(int format, >>> if (fileTypeInfo[format].versionOffset == -2) >>> return true; > > So you would like to see: > > if (fileTypeInfo[format].versionSize == 0) > return false; > Sent before I thought about

Re: [libvirt] [PATCH v2 06/15] util: Modify the FileTypeInfo to add a version size

2016-06-24 Thread John Ferlan
On 06/24/2016 09:28 AM, Peter Krempa wrote: > On Thu, Jun 23, 2016 at 13:29:02 -0400, John Ferlan wrote: >> The version field historically has been a 4 byte data; however, an upcoming >> new type will use a 2 byte version. So let's adjust for that now. >> >> Signed-off-by: John Ferlan

Re: [libvirt] [PATCH v2 06/15] util: Modify the FileTypeInfo to add a version size

2016-06-24 Thread Peter Krempa
On Thu, Jun 23, 2016 at 13:29:02 -0400, John Ferlan wrote: > The version field historically has been a 4 byte data; however, an upcoming > new type will use a 2 byte version. So let's adjust for that now. > > Signed-off-by: John Ferlan > --- > src/util/virstoragefile.c | 60

[libvirt] [PATCH v2 06/15] util: Modify the FileTypeInfo to add a version size

2016-06-23 Thread John Ferlan
The version field historically has been a 4 byte data; however, an upcoming new type will use a 2 byte version. So let's adjust for that now. Signed-off-by: John Ferlan --- src/util/virstoragefile.c | 60 +-- 1 file changed, 37