Re: [libvirt] [PATCH v2 07/10] conf: Optionally keep domains with invalid XML, but don't allow starting them

2015-12-13 Thread John Ferlan
[...] >>> + >>> +if (virFileReadAll(configFile, 1024*1024*10, ) < 0) >> >> Any reason to not use MAX_CONFIG_FILE_SIZE? Cannot imagine this >> failing, but I mention for consistency >> > > This was a copy-paste from somewhere else, but I will add > MAX_CONFIG_FILE_SIZE both here and to

Re: [libvirt] [PATCH v2 07/10] conf: Optionally keep domains with invalid XML, but don't allow starting them

2015-12-11 Thread Martin Kletzander
On Thu, Dec 10, 2015 at 03:18:29PM -0500, John Ferlan wrote: On 12/01/2015 12:35 PM, Martin Kletzander wrote: Add new parameter to virDomainObjListLoadConfig() and virDomainObjListLoadAllConfigs() that controls whether domains with invalid XML (which could not be parsed) should be kept in

Re: [libvirt] [PATCH v2 07/10] conf: Optionally keep domains with invalid XML, but don't allow starting them

2015-12-10 Thread John Ferlan
On 12/01/2015 12:35 PM, Martin Kletzander wrote: > Add new parameter to virDomainObjListLoadConfig() and > virDomainObjListLoadAllConfigs() that controls whether domains with > invalid XML (which could not be parsed) should be kept in order not to > lose track of them. For now, the parameter is

[libvirt] [PATCH v2 07/10] conf: Optionally keep domains with invalid XML, but don't allow starting them

2015-12-01 Thread Martin Kletzander
Add new parameter to virDomainObjListLoadConfig() and virDomainObjListLoadAllConfigs() that controls whether domains with invalid XML (which could not be parsed) should be kept in order not to lose track of them. For now, the parameter is set to false in all callers. Each driver can switch it to