Re: [libvirt] [PATCH v2 08/11] tests: qemuxml2argv cpu feature syntax

2016-12-16 Thread Jiri Denemark
On Fri, Dec 16, 2016 at 12:10:55 -0500, Collin L. Walling wrote: > On 12/15/2016 11:10 AM, Jiri Denemark wrote: > > We already have a lot of tests that use the ±feature syntax so there's > > no real need to add another one. However, we could use it as a negative > > test since s390 does not support

Re: [libvirt] [PATCH v2 08/11] tests: qemuxml2argv cpu feature syntax

2016-12-16 Thread Collin L. Walling
On 12/15/2016 11:10 AM, Jiri Denemark wrote: We already have a lot of tests that use the ±feature syntax so there's no real need to add another one. However, we could use it as a negative test since s390 does not support the old syntax. So how about: DO_TEST("cpu-s390-features", QEMU_CAPS_K

Re: [libvirt] [PATCH v2 08/11] tests: qemuxml2argv cpu feature syntax

2016-12-15 Thread Jiri Denemark
On Fri, Dec 09, 2016 at 14:38:37 -0500, Jason J. Herne wrote: > Test that libvirt generates the correct cpu feature syntax when > query-cpu-model-expansion is supported and when it is not. > > Signed-off-by: Jason J. Herne > --- > .../qemuxml2argv-cpu-features-post-qcme.args | 19 +

[libvirt] [PATCH v2 08/11] tests: qemuxml2argv cpu feature syntax

2016-12-09 Thread Jason J. Herne
Test that libvirt generates the correct cpu feature syntax when query-cpu-model-expansion is supported and when it is not. Signed-off-by: Jason J. Herne --- .../qemuxml2argv-cpu-features-post-qcme.args | 19 ++ .../qemuxml2argv-cpu-features-post-qcme.xml| 23 +++