Re: [libvirt] [PATCH v2 08/32] conf: Rework virStoragePoolDefParseXML

2019-02-11 Thread Ján Tomko
On Fri, Feb 08, 2019 at 01:37:02PM -0500, John Ferlan wrote: Rather than having an error path, let's rework the code to allocate and fill into an @def variable and then steal that into @ret when we are successful leaving just a cleanup: path. Signed-off-by: John Ferlan --- src/conf/storage_conf

[libvirt] [PATCH v2 08/32] conf: Rework virStoragePoolDefParseXML

2019-02-08 Thread John Ferlan
Rather than having an error path, let's rework the code to allocate and fill into an @def variable and then steal that into @ret when we are successful leaving just a cleanup: path. Signed-off-by: John Ferlan --- src/conf/storage_conf.c | 114 1 file chan