Re: [libvirt] [PATCH v2 1/2] qemu: make attaching disk partition to VM illegal

2019-10-02 Thread Pavel Mores
On Wed, Oct 02, 2019 at 02:04:28PM +0200, Michal Privoznik wrote: > On 10/2/19 1:11 PM, Daniel P. Berrangé wrote: > > On Wed, Oct 02, 2019 at 10:45:28AM +0200, Michal Privoznik wrote: > > > On 9/30/19 3:41 PM, Pavel Mores wrote: > > > > The way in which the qemu driver generates aliases for disks

Re: [libvirt] [PATCH v2 1/2] qemu: make attaching disk partition to VM illegal

2019-10-02 Thread Michal Privoznik
On 10/2/19 1:11 PM, Daniel P. Berrangé wrote: On Wed, Oct 02, 2019 at 10:45:28AM +0200, Michal Privoznik wrote: On 9/30/19 3:41 PM, Pavel Mores wrote: The way in which the qemu driver generates aliases for disks involves ignoring the partition number part of a target dev name. This means that

Re: [libvirt] [PATCH v2 1/2] qemu: make attaching disk partition to VM illegal

2019-10-02 Thread Daniel P . Berrangé
On Wed, Oct 02, 2019 at 10:45:28AM +0200, Michal Privoznik wrote: > On 9/30/19 3:41 PM, Pavel Mores wrote: > > The way in which the qemu driver generates aliases for disks involves > > ignoring the partition number part of a target dev name. This means that > > all partitions of a block device

Re: [libvirt] [PATCH v2 1/2] qemu: make attaching disk partition to VM illegal

2019-10-02 Thread Michal Privoznik
On 9/30/19 3:41 PM, Pavel Mores wrote: The way in which the qemu driver generates aliases for disks involves ignoring the partition number part of a target dev name. This means that all partitions of a block device and the device itself all end up with the same alias. If multiple such disks

Re: [libvirt] [PATCH v2 1/2] qemu: make attaching disk partition to VM illegal

2019-10-01 Thread Daniel P . Berrangé
On Mon, Sep 30, 2019 at 03:41:00PM +0200, Pavel Mores wrote: > The way in which the qemu driver generates aliases for disks involves > ignoring the partition number part of a target dev name. This means that > all partitions of a block device and the device itself all end up with the > same

[libvirt] [PATCH v2 1/2] qemu: make attaching disk partition to VM illegal

2019-09-30 Thread Pavel Mores
The way in which the qemu driver generates aliases for disks involves ignoring the partition number part of a target dev name. This means that all partitions of a block device and the device itself all end up with the same alias. If multiple such disks are specified in XML, the resulting name