Re: [libvirt] [PATCH v2 1/2] util: switch over to use keycodemapdb GIT submodule

2017-04-18 Thread Andrea Bolognani
On Wed, 2017-04-12 at 10:01 +0200, Andrea Bolognani wrote: > > > I'm also wondering whether we can avoid having all developers > > > run 'git submodule init && git submodule update' after these > > > changes have been pushed... > >   > > I assumed our blackmagic that deals with gnulib changing

Re: [libvirt] [PATCH v2 1/2] util: switch over to use keycodemapdb GIT submodule

2017-04-12 Thread Andrea Bolognani
On Fri, 2017-04-07 at 16:56 +0100, Daniel P. Berrange wrote: > > I'm also wondering whether we can avoid having all developers > > run 'git submodule init && git submodule update' after these > > changes have been pushed... >  > I assumed our blackmagic that deals with gnulib changing would > also

Re: [libvirt] [PATCH v2 1/2] util: switch over to use keycodemapdb GIT submodule

2017-04-07 Thread Daniel P. Berrange
On Fri, Apr 07, 2017 at 05:52:50PM +0200, Andrea Bolognani wrote: > On Fri, 2017-03-03 at 16:54 +, Daniel P. Berrange wrote: > [...] > > @@ -1,3 +1,6 @@ > >  [submodule "gnulib"] > >   path = .gnulib > >   url = git://git.sv.gnu.org/gnulib.git > > +[submodule "src/keycodemapdb"] > > +

Re: [libvirt] [PATCH v2 1/2] util: switch over to use keycodemapdb GIT submodule

2017-04-07 Thread Andrea Bolognani
On Fri, 2017-03-03 at 16:54 +, Daniel P. Berrange wrote: [...] > @@ -1,3 +1,6 @@ >  [submodule "gnulib"] >   path = .gnulib >   url = git://git.sv.gnu.org/gnulib.git > +[submodule "src/keycodemapdb"] > + path = src/keycodemapdb > + url =

[libvirt] [PATCH v2 1/2] util: switch over to use keycodemapdb GIT submodule

2017-03-03 Thread Daniel P. Berrange
A long time ago we imported the keymaps.csv file from GTK-VNC so we can do conversions between keycode sets. Meanwhile lots of bug fixes have gone into this CSV file and libvirt hasn't kept in sync. The keymaps.csv file and associated generator script has been pulled out of GTK-VNC into a