Re: [libvirt] [PATCH v2 1/3] qemu: refactor graphics code to not hardcode a single display

2012-11-12 Thread Jiri Denemark
On Sat, Nov 10, 2012 at 02:40:23 +0100, Alon Levy wrote: The check for a single display remains so no new functionality is added. --- v2 changes: removed enum, use virReportOOMError directly. use --patience added a one line label fix patch. The second patch changes a string that needs

Re: [libvirt] [PATCH v2 1/3] qemu: refactor graphics code to not hardcode a single display

2012-11-12 Thread Alon Levy
[snip] I'd prefer if the refactoring of qemuBuildCommandLine was separated from removing the limit for number of graphics cards. But since I already reviewed the patch and I don't want to do that again, I'm giving a formal ACK to this version (with the small issues fixed, of course).

[libvirt] [PATCH v2 1/3] qemu: refactor graphics code to not hardcode a single display

2012-11-09 Thread Alon Levy
The check for a single display remains so no new functionality is added. --- v2 changes: removed enum, use virReportOOMError directly. use --patience added a one line label fix patch. The second patch changes a string that needs to be translated - how do I go about it?