Re: [libvirt] [PATCH v2 1/4] tools: console: cleanup console on errors in main thread

2019-03-15 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 10:39:46AM +0300, Nikolay Shirokovskiy wrote: > We only check now for virObjectWait failures in virshRunConsole but > we'd better check and for other failures too. Anyway if failure > happened we need to shutdown console to stop delivering events > from event loop thread or

[libvirt] [PATCH v2 1/4] tools: console: cleanup console on errors in main thread

2019-03-13 Thread Nikolay Shirokovskiy
We only check now for virObjectWait failures in virshRunConsole but we'd better check and for other failures too. Anyway if failure happened we need to shutdown console to stop delivering events from event loop thread or we are in trouble as console is freed on virshRunConsole exit. We need to