On 2/19/19 6:00 PM, Eric Blake wrote:
> On 2/19/19 2:24 PM, Eric Blake wrote:
>
>>
>>> BTW: For the two callers that pass all 3 maybe it'd be good to change
>>> those to pass VIR_DOMAIN_XML_COMMON_FLAGS. Currently:
>>>
>>> * qemuMigrationCookieXMLFormat
>>> * qemuDomainSaveImageDefineXML
On 2/19/19 2:24 PM, Eric Blake wrote:
>
>> BTW: For the two callers that pass all 3 maybe it'd be good to change
>> those to pass VIR_DOMAIN_XML_COMMON_FLAGS. Currently:
>>
>> * qemuMigrationCookieXMLFormat
>> * qemuDomainSaveImageDefineXML
>
> Makes sense, although I might split it as a
On 2/19/19 3:33 PM, Eric Blake wrote:
> On 2/19/19 2:24 PM, Eric Blake wrote:
>
>>> Since this is limited to the GetXMLDesc processing wouldn't this limit
>>> the exposure in such a way that some new flag expecting some default
>>> action would not return expected or "new" results on the newer
On 2/19/19 2:24 PM, Eric Blake wrote:
>> Since this is limited to the GetXMLDesc processing wouldn't this limit
>> the exposure in such a way that some new flag expecting some default
>> action would not return expected or "new" results on the newer libvirt
>> vs. some older one? That is limited
On 2/19/19 1:31 PM, John Ferlan wrote:
>
>
> On 2/14/19 4:29 PM, Eric Blake wrote:
>> Many drivers had a comment that they did not validate the incoming
>> 'flags' to virDomainGetXMLDesc() because they were relying on
>> virDomainDefFormat() to do it instead. This used to be the case,
>> but
On 2/14/19 4:29 PM, Eric Blake wrote:
> Many drivers had a comment that they did not validate the incoming
> 'flags' to virDomainGetXMLDesc() because they were relying on
> virDomainDefFormat() to do it instead. This used to be the case,
> but regressed in commit 0ecd6851 (1.2.12), when all of
Many drivers had a comment that they did not validate the incoming
'flags' to virDomainGetXMLDesc() because they were relying on
virDomainDefFormat() to do it instead. This used to be the case,
but regressed in commit 0ecd6851 (1.2.12), when all of the drivers
were changed to pass 'flags' through
