Re: [libvirt] [PATCH v2 1/6] qemu: command: Rename and move qemuNetworkDriveGetPort

2017-07-24 Thread Peter Krempa
On Fri, Jul 21, 2017 at 07:58:52 -0400, John Ferlan wrote: > [...] > > Before it's too late... > > > + > > +/** > > + * virStringParsePort: > > + * @str: port number to parse > > + * @port: pointer to parse port into > > + * > > + * Parses a string representation of a network port and validates i

Re: [libvirt] [PATCH v2 1/6] qemu: command: Rename and move qemuNetworkDriveGetPort

2017-07-21 Thread John Ferlan
[...] Before it's too late... > + > +/** > + * virStringParsePort: > + * @str: port number to parse > + * @port: pointer to parse port into > + * > + * Parses a string representation of a network port and validates it. Returns > + * 0 on success and -1 on error. > + */ > +int > +virStringParsePor

[libvirt] [PATCH v2 1/6] qemu: command: Rename and move qemuNetworkDriveGetPort

2017-07-20 Thread Peter Krempa
Move it to virstring.c and improve it to parse and validate ports. New name is virStringParsePort. --- src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 18 +- src/util/virstring.c | 37 + src/util/virstring.h | 4 4 files