Re: [libvirt] [PATCH v2 1/8] Revert "prevent hot unplugging multi function PCI device"

2016-05-23 Thread Shivaprasad bhat
On Thu, May 19, 2016 at 11:13 PM, Laine Stump wrote: > If you're going to say in the commit that you're reverting something, you > should list the commit id of the patch you're reverting (even if, as in > this case, the revert couldn't be done with "git revert"). > > Usually,

Re: [libvirt] [PATCH v2 1/8] Revert "prevent hot unplugging multi function PCI device"

2016-05-19 Thread Laine Stump
If you're going to say in the commit that you're reverting something, you should list the commit id of the patch you're reverting (even if, as in this case, the revert couldn't be done with "git revert"). Usually, though, a revert is done to remove something that shouldn't have been committed

[libvirt] [PATCH v2 1/8] Revert "prevent hot unplugging multi function PCI device"

2016-05-18 Thread Shivaprasad G Bhat
This has to go. The unlugging is going to be supported. Signed-off-by: Shivaprasad G Bhat --- src/qemu/qemu_hotplug.c | 60 --- 1 file changed, 60 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c