Re: [libvirt] [PATCH v2 1/9] vircgroup: cleanup controllers not managed by systemd on error

2018-09-27 Thread Pavel Hrdina
On Thu, Sep 27, 2018 at 04:01:08PM +0200, Pavel Hrdina wrote: > On Thu, Sep 27, 2018 at 08:40:03AM -0400, John Ferlan wrote: > > > > > > On 9/20/18 4:54 AM, Pavel Hrdina wrote: > > > If virCgroupEnableMissingControllers() fails it could already create > > > some directories, we should clean it

Re: [libvirt] [PATCH v2 1/9] vircgroup: cleanup controllers not managed by systemd on error

2018-09-27 Thread Pavel Hrdina
On Thu, Sep 27, 2018 at 08:40:03AM -0400, John Ferlan wrote: > > > On 9/20/18 4:54 AM, Pavel Hrdina wrote: > > If virCgroupEnableMissingControllers() fails it could already create > > some directories, we should clean it up as well. > > > > Reviewed-by: Fabiano Fidêncio > > Signed-off-by:

Re: [libvirt] [PATCH v2 1/9] vircgroup: cleanup controllers not managed by systemd on error

2018-09-27 Thread John Ferlan
On 9/20/18 4:54 AM, Pavel Hrdina wrote: > If virCgroupEnableMissingControllers() fails it could already create > some directories, we should clean it up as well. > > Reviewed-by: Fabiano Fidêncio > Signed-off-by: Pavel Hrdina > --- > src/util/vircgroup.c | 25 +++-- > 1

Re: [libvirt] [PATCH v2 1/9] vircgroup: cleanup controllers not managed by systemd on error

2018-09-24 Thread Ján Tomko
On Thu, Sep 20, 2018 at 10:54:30AM +0200, Pavel Hrdina wrote: If virCgroupEnableMissingControllers() fails it could already create could have already created? I'm not good at the conditionals. some directories, we should clean it up as well. Reviewed-by: Fabiano Fidêncio Signed-off-by:

[libvirt] [PATCH v2 1/9] vircgroup: cleanup controllers not managed by systemd on error

2018-09-20 Thread Pavel Hrdina
If virCgroupEnableMissingControllers() fails it could already create some directories, we should clean it up as well. Reviewed-by: Fabiano Fidêncio Signed-off-by: Pavel Hrdina --- src/util/vircgroup.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git