Re: [libvirt] [PATCH v2 10/12] migration: refactor: prepare to reuse flag vs feature checks

2015-09-17 Thread Daniel P. Berrange
On Thu, Sep 10, 2015 at 04:20:22PM +0300, Nikolay Shirokovskiy wrote: > All toURI functions have same checks for flags and features compatibility for > direct and p2p case. Let's factor this checks out before we reuse common code > in toURI functions family. As a side affect we have a more clear

Re: [libvirt] [PATCH v2 10/12] migration: refactor: prepare to reuse flag vs feature checks

2015-09-17 Thread John Ferlan
On 09/10/2015 09:20 AM, Nikolay Shirokovskiy wrote: > All toURI functions have same checks for flags and features compatibility for > direct and p2p case. Let's factor this checks out before we reuse common code s/this/the > in toURI functions family. As a side affect we have a more clear code

[libvirt] [PATCH v2 10/12] migration: refactor: prepare to reuse flag vs feature checks

2015-09-10 Thread Nikolay Shirokovskiy
All toURI functions have same checks for flags and features compatibility for direct and p2p case. Let's factor this checks out before we reuse common code in toURI functions family. As a side affect we have a more clear code representation of uri passing conventions for p2p and direct cases.