Re: [libvirt] [PATCH v2 10/15] vbox: Process element in domain XML

2017-11-03 Thread Dawid Zamirski
On Fri, 2017-11-03 at 09:51 -0400, John Ferlan wrote: > > On 10/24/2017 03:35 PM, Dawid Zamirski wrote: > > > > +case VIR_DOMAIN_CONTROLLER_TYPE_SCSI: > > +VBOX_UTF8_TO_UTF16(VBOX_CONTROLLER_SCSI_NAME, > > &controllerName); > > +vboxBusType = StorageBus_SCSI; > > + > > +

Re: [libvirt] [PATCH v2 10/15] vbox: Process element in domain XML

2017-11-03 Thread Dawid Zamirski
On Fri, 2017-11-03 at 09:51 -0400, John Ferlan wrote: > > On 10/24/2017 03:35 PM, Dawid Zamirski wrote: > > This patch enables the VBOX driver to process the > > element > > in domain XML through which one can now customize the controller > > model. > > > > Since VirtualBox has two distinct SAS

Re: [libvirt] [PATCH v2 10/15] vbox: Process element in domain XML

2017-11-03 Thread John Ferlan
On 10/24/2017 03:35 PM, Dawid Zamirski wrote: > This patch enables the VBOX driver to process the element > in domain XML through which one can now customize the controller model. > > Since VirtualBox has two distinct SAS and SCSI they do not "map" > directly to libvirt XML, he VBOX driver uses

[libvirt] [PATCH v2 10/15] vbox: Process element in domain XML

2017-10-24 Thread Dawid Zamirski
This patch enables the VBOX driver to process the element in domain XML through which one can now customize the controller model. Since VirtualBox has two distinct SAS and SCSI they do not "map" directly to libvirt XML, he VBOX driver uses to create SAS controller in VBOX VM. Additionally once c