Re: [libvirt] [PATCH v2 11/12] migration: reuse flags vs features checks in toURI family

2015-09-18 Thread Nikolay Shirokovskiy
On 17.09.2015 18:07, John Ferlan wrote: > > > On 09/10/2015 09:20 AM, Nikolay Shirokovskiy wrote: >> Introduce a new function for the check. virDomainMigrateUnmanagedParams is >> not >> a good candidate for this functionality as it is used by migrate family >> functions too and its have its

Re: [libvirt] [PATCH v2 11/12] migration: reuse flags vs features checks in toURI family

2015-09-17 Thread Daniel P. Berrange
On Thu, Sep 10, 2015 at 04:20:23PM +0300, Nikolay Shirokovskiy wrote: > Introduce a new function for the check. virDomainMigrateUnmanagedParams is not > a good candidate for this functionality as it is used by migrate family > functions too and its have its own checks that are superset of

Re: [libvirt] [PATCH v2 11/12] migration: reuse flags vs features checks in toURI family

2015-09-17 Thread John Ferlan
On 09/10/2015 09:20 AM, Nikolay Shirokovskiy wrote: > Introduce a new function for the check. virDomainMigrateUnmanagedParams is not > a good candidate for this functionality as it is used by migrate family > functions too and its have its own checks that are superset of extracted and > we >

[libvirt] [PATCH v2 11/12] migration: reuse flags vs features checks in toURI family

2015-09-10 Thread Nikolay Shirokovskiy
Introduce a new function for the check. virDomainMigrateUnmanagedParams is not a good candidate for this functionality as it is used by migrate family functions too and its have its own checks that are superset of extracted and we don't need to check twice. Actually name of the function is