Re: [libvirt] [PATCH v2 12/12] migration: refactor: one return in forURI family functions

2015-09-18 Thread Nikolay Shirokovskiy
On 17.09.2015 18:22, John Ferlan wrote: > > > On 09/10/2015 09:20 AM, Nikolay Shirokovskiy wrote: >> May be a matter of a taste but this version with one return point in every >> function looks simplier to understand and to exetend too. Anyway after such > > s/exetend/extend > >> a heavy

Re: [libvirt] [PATCH v2 12/12] migration: refactor: one return in forURI family functions

2015-09-18 Thread Nikolay Shirokovskiy
On 17.09.2015 18:22, John Ferlan wrote: > > > On 09/10/2015 09:20 AM, Nikolay Shirokovskiy wrote: >> May be a matter of a taste but this version with one return point in every >> function looks simplier to understand and to exetend too. Anyway after such > > s/exetend/extend > >> a heavy

Re: [libvirt] [PATCH v2 12/12] migration: refactor: one return in forURI family functions

2015-09-17 Thread John Ferlan
On 09/10/2015 09:20 AM, Nikolay Shirokovskiy wrote: > May be a matter of a taste but this version with one return point in every > function looks simplier to understand and to exetend too. Anyway after such s/exetend/extend > a heavy refactoring a little cleanup will not hurt. > >

Re: [libvirt] [PATCH v2 12/12] migration: refactor: one return in forURI family functions

2015-09-17 Thread Daniel P. Berrange
On Thu, Sep 10, 2015 at 04:20:24PM +0300, Nikolay Shirokovskiy wrote: > May be a matter of a taste but this version with one return point in every > function looks simplier to understand and to exetend too. Anyway after such > a heavy refactoring a little cleanup will not hurt. > > Signed-off-by:

[libvirt] [PATCH v2 12/12] migration: refactor: one return in forURI family functions

2015-09-10 Thread Nikolay Shirokovskiy
May be a matter of a taste but this version with one return point in every function looks simplier to understand and to exetend too. Anyway after such a heavy refactoring a little cleanup will not hurt. Signed-off-by: Nikolay Shirokovskiy --- src/libvirt-domain.c |