Re: [libvirt] [PATCH v2 12/32] storage: Use VIR_AUTOFREE for storage backends

2019-02-11 Thread Ján Tomko
On Mon, Feb 11, 2019 at 10:14:56PM -0500, John Ferlan wrote: On 2/11/19 7:52 AM, Ján Tomko wrote: On Fri, Feb 08, 2019 at 01:37:06PM -0500, John Ferlan wrote: Let's make use of the auto __cleanup capabilities. This also allows for the cleanup of some goto paths. Signed-off-by: John Ferlan -

Re: [libvirt] [PATCH v2 12/32] storage: Use VIR_AUTOFREE for storage backends

2019-02-11 Thread John Ferlan
On 2/11/19 7:52 AM, Ján Tomko wrote: > On Fri, Feb 08, 2019 at 01:37:06PM -0500, John Ferlan wrote: >> Let's make use of the auto __cleanup capabilities. This also allows >> for the cleanup of some goto paths. >> >> Signed-off-by: John Ferlan >> --- >> src/storage/storage_backend.c 

Re: [libvirt] [PATCH v2 12/32] storage: Use VIR_AUTOFREE for storage backends

2019-02-11 Thread Ján Tomko
On Fri, Feb 08, 2019 at 01:37:06PM -0500, John Ferlan wrote: Let's make use of the auto __cleanup capabilities. This also allows for the cleanup of some goto paths. Signed-off-by: John Ferlan --- src/storage/storage_backend.c | 9 +-- src/storage/storage_backend_disk.c | 62

Re: [libvirt] [PATCH v2 12/32] storage: Use VIR_AUTOFREE for storage backends

2019-02-11 Thread John Ferlan
On 2/11/19 5:39 AM, Erik Skultety wrote: > On Fri, Feb 08, 2019 at 01:37:06PM -0500, John Ferlan wrote: >> Let's make use of the auto __cleanup capabilities. This also allows >> for the cleanup of some goto paths. >> >> Signed-off-by: John Ferlan >> --- > >> @@ -459,15 +454,15 @@ virStorageBac

Re: [libvirt] [PATCH v2 12/32] storage: Use VIR_AUTOFREE for storage backends

2019-02-11 Thread Erik Skultety
On Fri, Feb 08, 2019 at 01:37:06PM -0500, John Ferlan wrote: > Let's make use of the auto __cleanup capabilities. This also allows > for the cleanup of some goto paths. > > Signed-off-by: John Ferlan > --- > @@ -459,15 +454,15 @@ virStorageBackendLogicalFindPoolSourcesFunc(char > **const groups,

[libvirt] [PATCH v2 12/32] storage: Use VIR_AUTOFREE for storage backends

2019-02-08 Thread John Ferlan
Let's make use of the auto __cleanup capabilities. This also allows for the cleanup of some goto paths. Signed-off-by: John Ferlan --- src/storage/storage_backend.c | 9 +-- src/storage/storage_backend_disk.c | 62 ++--- src/storage/storage_backend_fs.c