Re: [libvirt] [PATCH v2 13/14] qemu_hotplug: delay sending DEVICE_REMOVED event until after *all* teardown

2019-03-26 Thread Ján Tomko
On Tue, Mar 26, 2019 at 01:15:33PM +0100, Peter Krempa wrote: On Mon, Mar 25, 2019 at 13:24:35 -0400, Laine Stump wrote: +return -1; +} +info = NULL; /* to prevent accidental use later */ // this is bridge [1] + switch ((virDomainDeviceType)dev->type) { ACK with the

Re: [libvirt] [PATCH v2 13/14] qemu_hotplug: delay sending DEVICE_REMOVED event until after *all* teardown

2019-03-26 Thread Peter Krempa
On Mon, Mar 25, 2019 at 13:24:35 -0400, Laine Stump wrote: > The VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event is sent after qemu has > responded to a device_del command with a DEVICE_DELETED event. Before > queuing the event, *some* of the final teardown of the device's > trappings in libvirt is done,

[libvirt] [PATCH v2 13/14] qemu_hotplug: delay sending DEVICE_REMOVED event until after *all* teardown

2019-03-25 Thread Laine Stump
The VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event is sent after qemu has responded to a device_del command with a DEVICE_DELETED event. Before queuing the event, *some* of the final teardown of the device's trappings in libvirt is done, but not *all* of it. As a result, an application may receive and