Re: [libvirt] [PATCH v2 13/29] conf: Merge virDomainStorageSourceFormat into virDomainDiskSourceFormat

2019-04-05 Thread Peter Krempa
On Thu, Apr 04, 2019 at 15:29:30 -0500, Eric Blake wrote: > On 4/4/19 3:16 PM, Eric Blake wrote: > > On 3/22/19 1:00 PM, Peter Krempa wrote: > >> There was only one caller, remove the unnecessary wrapper. > >> > >> Signed-off-by: Peter Krempa > >> --- > >> src/conf/domain_conf.c | 60

Re: [libvirt] [PATCH v2 13/29] conf: Merge virDomainStorageSourceFormat into virDomainDiskSourceFormat

2019-04-04 Thread Eric Blake
On 4/4/19 3:16 PM, Eric Blake wrote: > On 3/22/19 1:00 PM, Peter Krempa wrote: >> There was only one caller, remove the unnecessary wrapper. >> >> Signed-off-by: Peter Krempa >> --- >> src/conf/domain_conf.c | 60 -- >> 1 file changed, 23 insertions(+), 37

Re: [libvirt] [PATCH v2 13/29] conf: Merge virDomainStorageSourceFormat into virDomainDiskSourceFormat

2019-04-04 Thread Eric Blake
On 3/22/19 1:00 PM, Peter Krempa wrote: > There was only one caller, remove the unnecessary wrapper. > > Signed-off-by: Peter Krempa > --- > src/conf/domain_conf.c | 60 -- > 1 file changed, 23 insertions(+), 37 deletions(-) Alas, my backup code wants to

Re: [libvirt] [PATCH v2 13/29] conf: Merge virDomainStorageSourceFormat into virDomainDiskSourceFormat

2019-04-02 Thread Ján Tomko
On Fri, Mar 22, 2019 at 07:00:49PM +0100, Peter Krempa wrote: There was only one caller, remove the unnecessary wrapper. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 60 -- 1 file changed, 23 insertions(+), 37 deletions(-) Reviewed-by: Ján

[libvirt] [PATCH v2 13/29] conf: Merge virDomainStorageSourceFormat into virDomainDiskSourceFormat

2019-03-22 Thread Peter Krempa
There was only one caller, remove the unnecessary wrapper. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 60 -- 1 file changed, 23 insertions(+), 37 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index