Re: [libvirt] [PATCH v2 14/21] conf: Shorten names in virDomainChrSerialTarget enumeration

2017-11-24 Thread Andrea Bolognani
On Fri, 2017-11-24 at 12:12 +0100, Jiri Denemark wrote: > > Any application that's been coded sensibly will deal with the new > > values in a graceful manner, eg. displaying "unknown model" or > > something along the line rather than failing. > > Showing an unknown device and failing is not very

Re: [libvirt] [PATCH v2 14/21] conf: Shorten names in virDomainChrSerialTarget enumeration

2017-11-24 Thread Jiri Denemark
On Fri, Nov 24, 2017 at 11:10:42 +0100, Andrea Bolognani wrote: > On Thu, 2017-11-23 at 16:54 +0100, Pavel Hrdina wrote: > > On Tue, Nov 21, 2017 at 05:42:24PM +0100, Andrea Bolognani wrote: > > > Now that the target type is no longer formatted on the QEMU command > > > line, we don't need the

Re: [libvirt] [PATCH v2 14/21] conf: Shorten names in virDomainChrSerialTarget enumeration

2017-11-24 Thread Andrea Bolognani
On Thu, 2017-11-23 at 16:54 +0100, Pavel Hrdina wrote: > On Tue, Nov 21, 2017 at 05:42:24PM +0100, Andrea Bolognani wrote: > > Now that the target type is no longer formatted on the QEMU command > > line, we don't need the values to match the QEMU device names any > > longer, so we can shorten the

Re: [libvirt] [PATCH v2 14/21] conf: Shorten names in virDomainChrSerialTarget enumeration

2017-11-23 Thread Pavel Hrdina
On Tue, Nov 21, 2017 at 05:42:24PM +0100, Andrea Bolognani wrote: > Now that the target type is no longer formatted on the QEMU command > line, we don't need the values to match the QEMU device names any > longer, so we can shorten the names and reduce redundancy by dropping > the -serial suffix:

[libvirt] [PATCH v2 14/21] conf: Shorten names in virDomainChrSerialTarget enumeration

2017-11-21 Thread Andrea Bolognani
Now that the target type is no longer formatted on the QEMU command line, we don't need the values to match the QEMU device names any longer, so we can shorten the names and reduce redundancy by dropping the -serial suffix: this also has the nice side-effect that target type and address type will