Re: [libvirt] [PATCH v2 14/32] util: Fix virStorageBackendSCSINewLun error handling

2019-02-11 Thread Ján Tomko
On Fri, Feb 08, 2019 at 01:37:08PM -0500, John Ferlan wrote: Commit a523770c3 added @retval return processing for virStorageBackendUpdateVolInfo in order to allow a -2 to be return; however, upon successful completion @retval = 0 and if either the virStorageBackendSCSISerial or the

Re: [libvirt] [PATCH v2 14/32] util: Fix virStorageBackendSCSINewLun error handling

2019-02-11 Thread Erik Skultety
On Fri, Feb 08, 2019 at 01:37:08PM -0500, John Ferlan wrote: > Commit a523770c3 added @retval return processing for > virStorageBackendUpdateVolInfo in order to allow a -2 > to be return; however, upon successful completion > @retval = 0 and if either the virStorageBackendSCSISerial > or the

[libvirt] [PATCH v2 14/32] util: Fix virStorageBackendSCSINewLun error handling

2019-02-08 Thread John Ferlan
Commit a523770c3 added @retval return processing for virStorageBackendUpdateVolInfo in order to allow a -2 to be return; however, upon successful completion @retval = 0 and if either the virStorageBackendSCSISerial or the virStoragePoolObjAddVol failed, the method would return 0, but not add the