Re: [libvirt] [PATCH v2 15/23] util: convert virIdentity class to use GObject

2019-10-09 Thread Daniel P . Berrangé
On Wed, Oct 09, 2019 at 03:16:38PM +0200, Ján Tomko wrote: > On Wed, Oct 09, 2019 at 09:07:57AM +0200, Pavel Hrdina wrote: > > On Tue, Oct 08, 2019 at 07:08:25PM +0200, Ján Tomko wrote: > > > On Mon, Oct 07, 2019 at 06:14:17PM +0100, Daniel P. Berrangé wrote: > > > > Converting from virObject to GO

Re: [libvirt] [PATCH v2 15/23] util: convert virIdentity class to use GObject

2019-10-09 Thread Ján Tomko
On Wed, Oct 09, 2019 at 09:07:57AM +0200, Pavel Hrdina wrote: On Tue, Oct 08, 2019 at 07:08:25PM +0200, Ján Tomko wrote: On Mon, Oct 07, 2019 at 06:14:17PM +0100, Daniel P. Berrangé wrote: > Converting from virObject to GObject is reasonably straightforward, > as illustrated by this patch for vi

Re: [libvirt] [PATCH v2 15/23] util: convert virIdentity class to use GObject

2019-10-09 Thread Pavel Hrdina
On Tue, Oct 08, 2019 at 07:08:25PM +0200, Ján Tomko wrote: > On Mon, Oct 07, 2019 at 06:14:17PM +0100, Daniel P. Berrangé wrote: > > Converting from virObject to GObject is reasonably straightforward, > > as illustrated by this patch for virIdentity > > > > In the header file > > > > - Remove > >

Re: [libvirt] [PATCH v2 15/23] util: convert virIdentity class to use GObject

2019-10-08 Thread Ján Tomko
On Mon, Oct 07, 2019 at 06:14:17PM +0100, Daniel P. Berrangé wrote: Converting from virObject to GObject is reasonably straightforward, as illustrated by this patch for virIdentity In the header file - Remove typedef struct _virIdentity virIdentity - Add #define VIR_TYPE_IDENTITY vir

[libvirt] [PATCH v2 15/23] util: convert virIdentity class to use GObject

2019-10-07 Thread Daniel P . Berrangé
Converting from virObject to GObject is reasonably straightforward, as illustrated by this patch for virIdentity In the header file - Remove typedef struct _virIdentity virIdentity - Add #define VIR_TYPE_IDENTITY virIdentity_get_type () G_DECLARE_FINAL_TYPE (virIdentity, virId