Re: [libvirt] [PATCH v2 17/17] qemu: assume various QEMU 0.10 features are always available

2015-11-11 Thread Paolo Bonzini
On 10/11/2015 00:28, John Ferlan wrote: >} else if (STRPREFIX(arg, "-hd") || >STRPREFIX(arg, "-sd") || >STRPREFIX(arg, "-fd") || >STREQ(arg, "-cdrom")) { > WANT_VALUE(); -sd is for sdcards, not SCSI, so it should be

Re: [libvirt] [PATCH v2 17/17] qemu: assume various QEMU 0.10 features are always available

2015-11-10 Thread Daniel P. Berrange
On Mon, Nov 09, 2015 at 06:28:03PM -0500, John Ferlan wrote: > > > On 11/09/2015 11:24 AM, Daniel P. Berrange wrote: > > The -sdl and -net ...name=XXX arguments were both introduced > > in QEMU 0.10, so the QEMU driver can assume they are always > > available. > > > > The -sdl wasn't really

Re: [libvirt] [PATCH v2 17/17] qemu: assume various QEMU 0.10 features are always available

2015-11-10 Thread John Ferlan
On 11/10/2015 05:31 AM, Daniel P. Berrange wrote: > On Mon, Nov 09, 2015 at 06:28:03PM -0500, John Ferlan wrote: >> >> >> On 11/09/2015 11:24 AM, Daniel P. Berrange wrote: >>> The -sdl and -net ...name=XXX arguments were both introduced >>> in QEMU 0.10, so the QEMU driver can assume they are

Re: [libvirt] [PATCH v2 17/17] qemu: assume various QEMU 0.10 features are always available

2015-11-10 Thread Daniel P. Berrange
On Tue, Nov 10, 2015 at 06:22:32AM -0500, John Ferlan wrote: > > > On 11/10/2015 05:31 AM, Daniel P. Berrange wrote: > > On Mon, Nov 09, 2015 at 06:28:03PM -0500, John Ferlan wrote: > >> > >> > >> On 11/09/2015 11:24 AM, Daniel P. Berrange wrote: > >>> The -sdl and -net ...name=XXX arguments

Re: [libvirt] [PATCH v2 17/17] qemu: assume various QEMU 0.10 features are always available

2015-11-10 Thread John Ferlan
On 11/10/2015 06:43 AM, Daniel P. Berrange wrote: > On Tue, Nov 10, 2015 at 06:22:32AM -0500, John Ferlan wrote: >> >> >> On 11/10/2015 05:31 AM, Daniel P. Berrange wrote: >>> On Mon, Nov 09, 2015 at 06:28:03PM -0500, John Ferlan wrote: On 11/09/2015 11:24 AM, Daniel P. Berrange

[libvirt] [PATCH v2 17/17] qemu: assume various QEMU 0.10 features are always available

2015-11-09 Thread Daniel P. Berrange
The -sdl and -net ...name=XXX arguments were both introduced in QEMU 0.10, so the QEMU driver can assume they are always available. Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h

Re: [libvirt] [PATCH v2 17/17] qemu: assume various QEMU 0.10 features are always available

2015-11-09 Thread John Ferlan
On 11/09/2015 11:24 AM, Daniel P. Berrange wrote: > The -sdl and -net ...name=XXX arguments were both introduced > in QEMU 0.10, so the QEMU driver can assume they are always > available. > The -sdl wasn't really removed it seems - although it did me peeking into the rabbit hole for a make