Re: [libvirt] [PATCH v2 2/2] lxc: Rearrange order in lxcDomainUpdateDeviceFlags

2018-07-01 Thread Michal Prívozník
On 06/30/2018 04:51 PM, John Ferlan wrote: > Although commit e3497f3f noted that the LIVE option doesn't > matter and removed the call to virDomainDefCompatibleDevice, > it didn't go quite far enough and change the order of the checks > and rework the code to just handle the config change causing >

[libvirt] [PATCH v2 2/2] lxc: Rearrange order in lxcDomainUpdateDeviceFlags

2018-06-30 Thread John Ferlan
Although commit e3497f3f noted that the LIVE option doesn't matter and removed the call to virDomainDefCompatibleDevice, it didn't go quite far enough and change the order of the checks and rework the code to just handle the config change causing a failure after virDomainObjUpdateModificationImpact