Re: [libvirt] [PATCH v2 2/2] qemu: completely rework reference counting

2014-12-22 Thread John Ferlan
On 12/22/2014 04:02 PM, Martin Kletzander wrote: > On Mon, Dec 22, 2014 at 07:27:29AM -0500, John Ferlan wrote: >> >> My Coverity scan found two issues both FORWARD_NULL... >> >> >> qemuDomainLookupByName >> >> and >> >> qemuMigrationPrepareAny >> >> >> On 12/16/2014 05:15 AM, Martin Kletzander w

Re: [libvirt] [PATCH v2 2/2] qemu: completely rework reference counting

2014-12-22 Thread Martin Kletzander
On Mon, Dec 22, 2014 at 07:27:29AM -0500, John Ferlan wrote: My Coverity scan found two issues both FORWARD_NULL... qemuDomainLookupByName and qemuMigrationPrepareAny On 12/16/2014 05:15 AM, Martin Kletzander wrote: There is one problem that causes various errors in the daemon. When doma

Re: [libvirt] [PATCH v2 2/2] qemu: completely rework reference counting

2014-12-22 Thread John Ferlan
My Coverity scan found two issues both FORWARD_NULL... qemuDomainLookupByName and qemuMigrationPrepareAny On 12/16/2014 05:15 AM, Martin Kletzander wrote: > There is one problem that causes various errors in the daemon. When > domain is waiting for a job, it is unlocked while waiting on the

Re: [libvirt] [PATCH v2 2/2] qemu: completely rework reference counting

2014-12-21 Thread Martin Kletzander
On Tue, Dec 16, 2014 at 04:51:59PM +0100, Martin Kletzander wrote: ..., but I'll wait with the pushing so others have a chance to react. There's no reaction for a while now and since I'd like to push this in the early stage of a release cycle, I'm pushing it now. This touches almost all APIs

Re: [libvirt] [PATCH v2 2/2] qemu: completely rework reference counting

2014-12-16 Thread Martin Kletzander
On Tue, Dec 16, 2014 at 02:00:09PM +0100, Michal Privoznik wrote: On 16.12.2014 11:15, Martin Kletzander wrote: There is one problem that causes various errors in the daemon. When domain is waiting for a job, it is unlocked while waiting on the condition. However, if that domain is for example

Re: [libvirt] [PATCH v2 2/2] qemu: completely rework reference counting

2014-12-16 Thread Michal Privoznik
On 16.12.2014 11:15, Martin Kletzander wrote: There is one problem that causes various errors in the daemon. When domain is waiting for a job, it is unlocked while waiting on the condition. However, if that domain is for example transient and being removed in another API (e.g. cancelling incomi

[libvirt] [PATCH v2 2/2] qemu: completely rework reference counting

2014-12-16 Thread Martin Kletzander
There is one problem that causes various errors in the daemon. When domain is waiting for a job, it is unlocked while waiting on the condition. However, if that domain is for example transient and being removed in another API (e.g. cancelling incoming migration), it get's unref'd. If the first c

Re: [libvirt] [PATCH v2 2/2] qemu: completely rework reference counting

2014-12-09 Thread Peter Krempa
On 12/05/14 15:03, Martin Kletzander wrote: > There is one problem that causes various errors in the daemon. When > domain is waiting for a job, it is unlocked while waiting on the > condition. However, if that domain is for example transient and being > removed in another API (e.g. cancelling in

Re: [libvirt] [PATCH v2 2/2] qemu: completely rework reference counting

2014-12-09 Thread Martin Kletzander
On Mon, Dec 08, 2014 at 07:57:50PM +0100, Peter Krempa wrote: On 12/05/14 15:03, Martin Kletzander wrote: There is one problem that causes various errors in the daemon. When domain is waiting for a job, it is unlocked while waiting on the condition. However, if that domain is for example trans

Re: [libvirt] [PATCH v2 2/2] qemu: completely rework reference counting

2014-12-08 Thread Peter Krempa
On 12/05/14 15:03, Martin Kletzander wrote: > There is one problem that causes various errors in the daemon. When > domain is waiting for a job, it is unlocked while waiting on the > condition. However, if that domain is for example transient and being > removed in another API (e.g. cancelling in

[libvirt] [PATCH v2 2/2] qemu: completely rework reference counting

2014-12-05 Thread Martin Kletzander
There is one problem that causes various errors in the daemon. When domain is waiting for a job, it is unlocked while waiting on the condition. However, if that domain is for example transient and being removed in another API (e.g. cancelling incoming migration), it get's unref'd. If the first c