Re: [libvirt] [PATCH v2 2/2] qemuProcessStop: Remove image metadata for running mirror jobs

2019-11-21 Thread Peter Krempa
On Thu, Nov 21, 2019 at 17:00:37 +0100, Michal Privoznik wrote: > On 11/21/19 3:31 PM, Peter Krempa wrote: > > On Thu, Nov 21, 2019 at 14:02:49 +0100, Michal Privoznik wrote: > > > On 11/20/19 3:22 PM, Peter Krempa wrote: > > > > > > New commit message: > > qemuProcessStop: Remove image meta

Re: [libvirt] [PATCH v2 2/2] qemuProcessStop: Remove image metadata for running mirror jobs

2019-11-21 Thread Michal Privoznik
On 11/21/19 3:31 PM, Peter Krempa wrote: On Thu, Nov 21, 2019 at 14:02:49 +0100, Michal Privoznik wrote: On 11/20/19 3:22 PM, Peter Krempa wrote: New commit message: qemuProcessStop: Remove image metadata for running mirror jobs If user starts a blockcommit or a blockcopy then we m

Re: [libvirt] [PATCH v2 2/2] qemuProcessStop: Remove image metadata for running mirror jobs

2019-11-21 Thread Peter Krempa
On Thu, Nov 21, 2019 at 14:02:49 +0100, Michal Privoznik wrote: > On 11/20/19 3:22 PM, Peter Krempa wrote: > > > > Okay, how about this commit message: > > qemuProcessStop: Remove image metadata for running mirror jobs > > If user starts a blockcommit without --pivot or a blockcopy also > withou

Re: [libvirt] [PATCH v2 2/2] qemuProcessStop: Remove image metadata for running mirror jobs

2019-11-21 Thread Michal Privoznik
On 11/20/19 3:22 PM, Peter Krempa wrote: > Okay, how about this commit message: qemuProcessStop: Remove image metadata for running mirror jobs If user starts a blockcommit without --pivot or a blockcopy also without --pivot then we modify access for qemu on both images and leave it like that un

Re: [libvirt] [PATCH v2 2/2] qemuProcessStop: Remove image metadata for running mirror jobs

2019-11-20 Thread Peter Krempa
On Wed, Nov 20, 2019 at 15:10:17 +0100, Michal Privoznik wrote: > On 11/20/19 12:17 PM, Peter Krempa wrote: > > On Tue, Nov 19, 2019 at 14:15:12 +0100, Michal Privoznik wrote: > > > If user starts a blockcommit without --pivot or a blockcopy also > > > without --pivot then we modify access for qemu

Re: [libvirt] [PATCH v2 2/2] qemuProcessStop: Remove image metadata for running mirror jobs

2019-11-20 Thread Michal Privoznik
On 11/20/19 12:17 PM, Peter Krempa wrote: On Tue, Nov 19, 2019 at 14:15:12 +0100, Michal Privoznik wrote: If user starts a blockcommit without --pivot or a blockcopy also without --pivot then we modify access for qemu on both images and leave it like that until pivot is executed. So far so good.

Re: [libvirt] [PATCH v2 2/2] qemuProcessStop: Remove image metadata for running mirror jobs

2019-11-20 Thread Peter Krempa
On Tue, Nov 19, 2019 at 14:15:12 +0100, Michal Privoznik wrote: > If user starts a blockcommit without --pivot or a blockcopy also > without --pivot then we modify access for qemu on both images and > leave it like that until pivot is executed. So far so good. > Problem is, if user instead of issui

[libvirt] [PATCH v2 2/2] qemuProcessStop: Remove image metadata for running mirror jobs

2019-11-19 Thread Michal Privoznik
If user starts a blockcommit without --pivot or a blockcopy also without --pivot then we modify access for qemu on both images and leave it like that until pivot is executed. So far so good. Problem is, if user instead of issuing pivot calls destroy on the domain or if qemu dies whilst executing th