Re: [libvirt] [PATCH v2 2/3] Fix more switch fallthrough identified by gcc8

2018-02-13 Thread Daniel P . Berrangé
On Tue, Feb 13, 2018 at 04:57:06PM +, Daniel P. Berrangé wrote: > GCC 8 became more fussy/clear about detecting switch > fallthroughs. First it doesn't like it if you have > a fallthrough attribute that is not before a case > statement. e.g. > >FOO: >BAR: >WIZZ: > ATTRIBUTE_F

[libvirt] [PATCH v2 2/3] Fix more switch fallthrough identified by gcc8

2018-02-13 Thread Daniel P . Berrangé
GCC 8 became more fussy/clear about detecting switch fallthroughs. First it doesn't like it if you have a fallthrough attribute that is not before a case statement. e.g. FOO: BAR: WIZZ: ATTRIBUTE_FALLTHROUGH; Is unacceptable as there's no final case statement, so while FOO & BAR ar