On Fri, Sep 07, 2018 at 11:10:14AM -0600, Jim Fehlig wrote:
> On 09/06/2018 03:06 PM, Marek Marczykowski-Górecki wrote:
>
> A few additional comments came to mind while looking at this patch again...
Perfect timing, I was just going to hit "send" on v3...
> > > > +/* Unlock virDomainObjPtr
On 09/06/2018 03:06 PM, Marek Marczykowski-Górecki wrote:
A few additional comments came to mind while looking at this patch again...
On Thu, Sep 06, 2018 at 02:58:30PM -0600, Jim Fehlig wrote:
On 09/03/2018 04:09 PM, Marek Marczykowski-Górecki wrote:
Signed-off-by: Marek
On Thu, Sep 06, 2018 at 02:58:30PM -0600, Jim Fehlig wrote:
> On 09/03/2018 04:09 PM, Marek Marczykowski-Górecki wrote:
> > Signed-off-by: Marek Marczykowski-Górecki
> > ---
> > Changes in v2:
> > - use virDomainObjEndAPI
> > - drop duplicated error reporting on virDomainObjIsActive
> > -
On 09/03/2018 04:09 PM, Marek Marczykowski-Górecki wrote:
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- use virDomainObjEndAPI
- drop duplicated error reporting on virDomainObjIsActive
- bump version comment to 4.8.0
You missed some other comments from V1. I'll repeat
Signed-off-by: Marek Marczykowski-Górecki
---
Changes in v2:
- use virDomainObjEndAPI
- drop duplicated error reporting on virDomainObjIsActive
- bump version comment to 4.8.0
---
src/libxl/libxl_driver.c | 121 -
1 file changed, 121 insertions(+)
diff