Re: [libvirt] [PATCH v2 2/3] libxl: implement virDomainPM* functions

2018-09-07 Thread Marek Marczykowski-Górecki
On Fri, Sep 07, 2018 at 11:10:14AM -0600, Jim Fehlig wrote: > On 09/06/2018 03:06 PM, Marek Marczykowski-Górecki wrote: > > A few additional comments came to mind while looking at this patch again... Perfect timing, I was just going to hit "send" on v3... > > > > +/* Unlock virDomainObjPtr

Re: [libvirt] [PATCH v2 2/3] libxl: implement virDomainPM* functions

2018-09-07 Thread Jim Fehlig
On 09/06/2018 03:06 PM, Marek Marczykowski-Górecki wrote: A few additional comments came to mind while looking at this patch again... On Thu, Sep 06, 2018 at 02:58:30PM -0600, Jim Fehlig wrote: On 09/03/2018 04:09 PM, Marek Marczykowski-Górecki wrote: Signed-off-by: Marek

Re: [libvirt] [PATCH v2 2/3] libxl: implement virDomainPM* functions

2018-09-06 Thread Marek Marczykowski-Górecki
On Thu, Sep 06, 2018 at 02:58:30PM -0600, Jim Fehlig wrote: > On 09/03/2018 04:09 PM, Marek Marczykowski-Górecki wrote: > > Signed-off-by: Marek Marczykowski-Górecki > > --- > > Changes in v2: > > - use virDomainObjEndAPI > > - drop duplicated error reporting on virDomainObjIsActive > > -

Re: [libvirt] [PATCH v2 2/3] libxl: implement virDomainPM* functions

2018-09-06 Thread Jim Fehlig
On 09/03/2018 04:09 PM, Marek Marczykowski-Górecki wrote: Signed-off-by: Marek Marczykowski-Górecki --- Changes in v2: - use virDomainObjEndAPI - drop duplicated error reporting on virDomainObjIsActive - bump version comment to 4.8.0 You missed some other comments from V1. I'll repeat

[libvirt] [PATCH v2 2/3] libxl: implement virDomainPM* functions

2018-09-03 Thread Marek Marczykowski-Górecki
Signed-off-by: Marek Marczykowski-Górecki --- Changes in v2: - use virDomainObjEndAPI - drop duplicated error reporting on virDomainObjIsActive - bump version comment to 4.8.0 --- src/libxl/libxl_driver.c | 121 - 1 file changed, 121 insertions(+) diff