Re: [libvirt] [PATCH v2 2/3] util: enum: Add NULL 'label' arg VIR_ENUM_IMPL calls

2019-04-17 Thread Eric Blake
On 4/17/19 10:56 AM, Cole Robinson wrote: > > So broadly I think the options are > > - Flip the switch. Double error reporting until we remove now redundant > calls. Worse error reporting in some cases like tristate and > virstoragetype without special consideration. No or less issues with >

Re: [libvirt] [PATCH v2 2/3] util: enum: Add NULL 'label' arg VIR_ENUM_IMPL calls

2019-04-17 Thread Cole Robinson
On 4/17/19 3:29 AM, Peter Krempa wrote: > On Tue, Apr 16, 2019 at 12:02:41 -0400, Cole Robinson wrote: >> On 4/16/19 5:11 AM, Michal Privoznik wrote: >>> On 4/16/19 8:32 AM, Peter Krempa wrote: On Mon, Apr 15, 2019 at 17:26:41 -0400, Cole Robinson wrote: > Allow passing in a 'label'

Re: [libvirt] [PATCH v2 2/3] util: enum: Add NULL 'label' arg VIR_ENUM_IMPL calls

2019-04-17 Thread Peter Krempa
On Tue, Apr 16, 2019 at 12:02:41 -0400, Cole Robinson wrote: > On 4/16/19 5:11 AM, Michal Privoznik wrote: > > On 4/16/19 8:32 AM, Peter Krempa wrote: > >> On Mon, Apr 15, 2019 at 17:26:41 -0400, Cole Robinson wrote: > >>> Allow passing in a 'label' string for raising errors from > >>>

Re: [libvirt] [PATCH v2 2/3] util: enum: Add NULL 'label' arg VIR_ENUM_IMPL calls

2019-04-16 Thread Cole Robinson
On 4/16/19 5:11 AM, Michal Privoznik wrote: > On 4/16/19 8:32 AM, Peter Krempa wrote: >> On Mon, Apr 15, 2019 at 17:26:41 -0400, Cole Robinson wrote: >>> Allow passing in a 'label' string for raising errors from >>> ToString/FromString calls. Adjust all VIR_ENUM_IMPL calls to >>> pass in NULL to

Re: [libvirt] [PATCH v2 2/3] util: enum: Add NULL 'label' arg VIR_ENUM_IMPL calls

2019-04-16 Thread Michal Privoznik
On 4/16/19 8:32 AM, Peter Krempa wrote: On Mon, Apr 15, 2019 at 17:26:41 -0400, Cole Robinson wrote: Allow passing in a 'label' string for raising errors from ToString/FromString calls. Adjust all VIR_ENUM_IMPL calls to pass in NULL to disable error reporting. We will add strings at a later

Re: [libvirt] [PATCH v2 2/3] util: enum: Add NULL 'label' arg VIR_ENUM_IMPL calls

2019-04-16 Thread Peter Krempa
On Mon, Apr 15, 2019 at 17:26:41 -0400, Cole Robinson wrote: > Allow passing in a 'label' string for raising errors from > ToString/FromString calls. Adjust all VIR_ENUM_IMPL calls to > pass in NULL to disable error reporting. We will add strings at > a later time. I think that rather than

[libvirt] [PATCH v2 2/3] util: enum: Add NULL 'label' arg VIR_ENUM_IMPL calls

2019-04-15 Thread Cole Robinson
Allow passing in a 'label' string for raising errors from ToString/FromString calls. Adjust all VIR_ENUM_IMPL calls to pass in NULL to disable error reporting. We will add strings at a later time. Signed-off-by: Cole Robinson --- docs/apibuild.py | 14 ++