Re: [libvirt] [PATCH v2 2/3] virTestCompareToULL: Rename local variables

2019-02-22 Thread Andrea Bolognani
On Wed, 2019-02-20 at 14:20 +0100, Michal Privoznik wrote: > The current naming makes it hard for me to see which holds the > expected value and which holds the actual value. Rename them to > make it obvious. > > Signed-off-by: Michal Privoznik > --- > tests/testutils.c | 10 +- > 1

Re: [libvirt] [PATCH v2 2/3] virTestCompareToULL: Rename local variables

2019-02-20 Thread Ján Tomko
On Wed, Feb 20, 2019 at 02:20:09PM +0100, Michal Privoznik wrote: The current naming makes it hard for me to see which holds the expected value and which holds the actual value. Rename them to make it obvious. Signed-off-by: Michal Privoznik --- tests/testutils.c | 10 +- 1 file

Re: [libvirt] [PATCH v2 2/3] virTestCompareToULL: Rename local variables

2019-02-20 Thread Martin Kletzander
On Wed, Feb 20, 2019 at 02:20:09PM +0100, Michal Privoznik wrote: The current naming makes it hard for me to see which holds the expected value and which holds the actual value. Rename them to make it obvious. Well, the naming was confusing because of the function parameters, so I would

[libvirt] [PATCH v2 2/3] virTestCompareToULL: Rename local variables

2019-02-20 Thread Michal Privoznik
The current naming makes it hard for me to see which holds the expected value and which holds the actual value. Rename them to make it obvious. Signed-off-by: Michal Privoznik --- tests/testutils.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/testutils.c