Re: [libvirt] [PATCH v2 2/4] qemu: block: use the delete flag to delete snapshot images if requested

2019-11-21 Thread Peter Krempa
On Thu, Nov 21, 2019 at 09:31:41 +0100, Pavel Mores wrote: > On Wed, Nov 20, 2019 at 12:11:32PM +0100, Peter Krempa wrote: > > On Wed, Nov 20, 2019 at 11:44:53 +0100, Pavel Mores wrote: > > > When blockcommit finishes successfully, one of the > > > qemuBlockJobProcessEventCompletedCommit() and > >

Re: [libvirt] [PATCH v2 2/4] qemu: block: use the delete flag to delete snapshot images if requested

2019-11-21 Thread Pavel Mores
On Wed, Nov 20, 2019 at 12:11:32PM +0100, Peter Krempa wrote: > On Wed, Nov 20, 2019 at 11:44:53 +0100, Pavel Mores wrote: > > When blockcommit finishes successfully, one of the > > qemuBlockJobProcessEventCompletedCommit() and > > qemuBlockJobProcessEventCompletedActiveCommit() event handlers is

Re: [libvirt] [PATCH v2 2/4] qemu: block: use the delete flag to delete snapshot images if requested

2019-11-20 Thread Peter Krempa
On Wed, Nov 20, 2019 at 14:56:18 +0100, Pavel Mores wrote: > On Wed, Nov 20, 2019 at 12:11:32PM +0100, Peter Krempa wrote: > > On Wed, Nov 20, 2019 at 11:44:53 +0100, Pavel Mores wrote: > > > When blockcommit finishes successfully, one of the > > > qemuBlockJobProcessEventCompletedCommit() and > >

Re: [libvirt] [PATCH v2 2/4] qemu: block: use the delete flag to delete snapshot images if requested

2019-11-20 Thread Pavel Mores
On Wed, Nov 20, 2019 at 12:11:32PM +0100, Peter Krempa wrote: > On Wed, Nov 20, 2019 at 11:44:53 +0100, Pavel Mores wrote: > > When blockcommit finishes successfully, one of the > > qemuBlockJobProcessEventCompletedCommit() and > > qemuBlockJobProcessEventCompletedActiveCommit() event handlers is

Re: [libvirt] [PATCH v2 2/4] qemu: block: use the delete flag to delete snapshot images if requested

2019-11-20 Thread Peter Krempa
On Wed, Nov 20, 2019 at 11:44:53 +0100, Pavel Mores wrote: > When blockcommit finishes successfully, one of the > qemuBlockJobProcessEventCompletedCommit() and > qemuBlockJobProcessEventCompletedActiveCommit() event handlers is called. > This is where the delete flag (stored in

[libvirt] [PATCH v2 2/4] qemu: block: use the delete flag to delete snapshot images if requested

2019-11-20 Thread Pavel Mores
When blockcommit finishes successfully, one of the qemuBlockJobProcessEventCompletedCommit() and qemuBlockJobProcessEventCompletedActiveCommit() event handlers is called. This is where the delete flag (stored in qemuBlockJobCommitData since the previous commit) can actually be used to delete the