Re: [libvirt] [PATCH v2 2/4] qemu_firmware: Introduce @want variable to qemuFirmwareMatchDomain()

2020-01-08 Thread Michal Privoznik
On 1/7/20 8:08 PM, Daniel P. Berrangé wrote: On Tue, Jan 07, 2020 at 02:43:23PM +0100, Michal Privoznik wrote: This simplifies condition when matching FW interface by having a single line condition instead of multiline one. Also, it prepares the code for future expansion. Signed-off-by: Michal

Re: [libvirt] [PATCH v2 2/4] qemu_firmware: Introduce @want variable to qemuFirmwareMatchDomain()

2020-01-07 Thread Daniel P . Berrangé
On Tue, Jan 07, 2020 at 02:43:23PM +0100, Michal Privoznik wrote: > This simplifies condition when matching FW interface by having a > single line condition instead of multiline one. Also, it prepares > the code for future expansion. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_firm

Re: [libvirt] [PATCH v2 2/4] qemu_firmware: Introduce @want variable to qemuFirmwareMatchDomain()

2020-01-07 Thread Daniel P . Berrangé
On Tue, Jan 07, 2020 at 02:43:23PM +0100, Michal Privoznik wrote: > This simplifies condition when matching FW interface by having a > single line condition instead of multiline one. Also, it prepares > the code for future expansion. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_firm

[libvirt] [PATCH v2 2/4] qemu_firmware: Introduce @want variable to qemuFirmwareMatchDomain()

2020-01-07 Thread Michal Privoznik
This simplifies condition when matching FW interface by having a single line condition instead of multiline one. Also, it prepares the code for future expansion. Signed-off-by: Michal Privoznik --- src/qemu/qemu_firmware.c | 25 + 1 file changed, 21 insertions(+), 4 delet