Re: [libvirt] [PATCH v2 2/4] tests: qemuxml2argv: move DO_CAPS_TEST* qemuCaps init

2019-03-22 Thread Andrea Bolognani
On Thu, 2019-03-21 at 15:55 -0400, Cole Robinson wrote: [...] > +if (!(qemuCaps = > qemuTestParseCapabilitiesArch(virArchFromString(capsarch), > + capsfile))) > +goto cleanup; I'd put curly brackets around the body here. [

[libvirt] [PATCH v2 2/4] tests: qemuxml2argv: move DO_CAPS_TEST* qemuCaps init

2019-03-21 Thread Cole Robinson
Move DO_CAPS_TEST* qemuCaps init and all the associated setup into testInfoSetArgs, adding ARG_CAPS_ARCH and ARG_CAPS_VER options and using those to build the capsfile path locally Signed-off-by: Cole Robinson --- tests/qemuxml2argvtest.c | 69 +++- 1 file cha