Re: [libvirt] [PATCH v2 2/5] qemu: Use correct domain xml flag

2019-02-19 Thread John Ferlan
On 2/14/19 4:29 PM, Eric Blake wrote: > Although VIR_DOMAIN_DEF_FORMAT_INACTIVE and VIR_DOMAIN_XML_INACTIVE > happen to have the same value (1<<1), they come from different enums; > and it is nicer to reason about a 'flags' variable if all uses of > that variable are compared against the same

[libvirt] [PATCH v2 2/5] qemu: Use correct domain xml flag

2019-02-14 Thread Eric Blake
Although VIR_DOMAIN_DEF_FORMAT_INACTIVE and VIR_DOMAIN_XML_INACTIVE happen to have the same value (1<<1), they come from different enums; and it is nicer to reason about a 'flags' variable if all uses of that variable are compared against the same enum type. Messed up in commit 06f75ff2 (3.8.0).