[libvirt] [PATCH v2 2/5] tests: Initialize basic capabilities properly

2017-03-29 Thread Andrea Bolognani
The capabilities used in test cases should match those used during normal operation for the tests to make any sense. --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capabilities.h | 2 ++ tests/qemuxml2argvdat

Re: [libvirt] [PATCH v2 2/5] tests: Initialize basic capabilities properly

2017-03-29 Thread John Ferlan
On 03/29/2017 10:08 AM, Andrea Bolognani wrote: > The capabilities used in test cases should match those used > during normal operation for the tests to make any sense. Could you add just a bit of text about why all -no-acpi is removed (mostly) and why -no-hpet is added to a couple? It's essent

Re: [libvirt] [PATCH v2 2/5] tests: Initialize basic capabilities properly

2017-03-30 Thread Andrea Bolognani
On Wed, 2017-03-29 at 19:50 -0400, John Ferlan wrote: > > The capabilities used in test cases should match those used > > during normal operation for the tests to make any sense. >  > Could you add just a bit of text about why all -no-acpi is removed > (mostly) and why -no-hpet is added to a couple

Re: [libvirt] [PATCH v2 2/5] tests: Initialize basic capabilities properly

2017-04-05 Thread Ján Tomko
On Wed, Mar 29, 2017 at 04:08:53PM +0200, Andrea Bolognani wrote: The capabilities used in test cases should match those used during normal operation for the tests to make any sense. --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capabilities.h

Re: [libvirt] [PATCH v2 2/5] tests: Initialize basic capabilities properly

2017-04-05 Thread Andrea Bolognani
On Wed, 2017-04-05 at 12:04 +0200, Ján Tomko wrote: [...] > > @@ -510,6 +510,8 @@ int virQEMUCapsParseHelpStr(const char *qemu, > > const char *qmperr); > > /* Only for use by test suite */ > > int virQEMUCapsParseDeviceStr(virQEMUCapsPtr qemuCaps, const char *str); > >