Re: [libvirt] [PATCH v2 2/6] block/dirty-bitmaps: rename frozen predicate helper

2019-02-22 Thread John Snow
On 2/19/19 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: > 19.02.2019 1:32, John Snow wrote: >> >> >> On 2/18/19 8:57 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 14.02.2019 2:23, John Snow wrote: "Frozen" was a good description a long time ago, but it isn't adequate now. Rename the

Re: [libvirt] [PATCH v2 2/6] block/dirty-bitmaps: rename frozen predicate helper

2019-02-22 Thread Vladimir Sementsov-Ogievskiy
18.02.2019 16:57, Vladimir Sementsov-Ogievskiy wrote: > 14.02.2019 2:23, John Snow wrote: >> "Frozen" was a good description a long time ago, but it isn't adequate now. >> Rename the frozen predicate to has_successor to make the semantics of the >> predicate more clear to outside callers. >> >> In

Re: [libvirt] [PATCH v2 2/6] block/dirty-bitmaps: rename frozen predicate helper

2019-02-19 Thread Vladimir Sementsov-Ogievskiy
19.02.2019 1:32, John Snow wrote: > > > On 2/18/19 8:57 AM, Vladimir Sementsov-Ogievskiy wrote: >> 14.02.2019 2:23, John Snow wrote: >>> "Frozen" was a good description a long time ago, but it isn't adequate now. >>> Rename the frozen predicate to has_successor to make the semantics of the >>>

Re: [libvirt] [PATCH v2 2/6] block/dirty-bitmaps: rename frozen predicate helper

2019-02-18 Thread John Snow
On 2/18/19 8:57 AM, Vladimir Sementsov-Ogievskiy wrote: > 14.02.2019 2:23, John Snow wrote: >> "Frozen" was a good description a long time ago, but it isn't adequate now. >> Rename the frozen predicate to has_successor to make the semantics of the >> predicate more clear to outside callers. >>

Re: [libvirt] [PATCH v2 2/6] block/dirty-bitmaps: rename frozen predicate helper

2019-02-18 Thread Vladimir Sementsov-Ogievskiy
14.02.2019 2:23, John Snow wrote: > "Frozen" was a good description a long time ago, but it isn't adequate now. > Rename the frozen predicate to has_successor to make the semantics of the > predicate more clear to outside callers. > > In the process, remove some calls to frozen() that no longer

Re: [libvirt] [PATCH v2 2/6] block/dirty-bitmaps: rename frozen predicate helper

2019-02-13 Thread Eric Blake
On 2/13/19 5:23 PM, John Snow wrote: > "Frozen" was a good description a long time ago, but it isn't adequate now. > Rename the frozen predicate to has_successor to make the semantics of the > predicate more clear to outside callers. > > In the process, remove some calls to frozen() that no

[libvirt] [PATCH v2 2/6] block/dirty-bitmaps: rename frozen predicate helper

2019-02-13 Thread John Snow
"Frozen" was a good description a long time ago, but it isn't adequate now. Rename the frozen predicate to has_successor to make the semantics of the predicate more clear to outside callers. In the process, remove some calls to frozen() that no longer semantically make sense. For enabled and